Hackerrank All Women's Codesprint 2019: Name the ProductMaximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors

Help with identifying unique aircraft over NE Pennsylvania

What are rules for concealing thieves tools (or items in general)?

Why do I have a large white artefact on the rendered image?

Is VPN a layer 3 concept?

How to balance a monster modification (zombie)?

Print a physical multiplication table

Exposing a company lying about themselves in a tightly knit industry: Is my career at risk on the long run?

Writing in a Christian voice

Should a narrator ever describe things based on a characters view instead of fact?

Do I need an EFI partition for each 18.04 ubuntu I have on my HD?

Have any astronauts/cosmonauts died in space?

Why I don't get the wanted width of tcbox?

Someone scrambled my calling sign- who am I?

Weird lines in Microsoft Word

How can I create URL shortcuts/redirects for task/diff IDs in Phabricator?

When did hardware antialiasing start being available?

is this saw blade faulty?

Turning a hard to access nut?

Unfrosted light bulb

How to test the sharpness of a knife?

Does convergence of polynomials imply that of its coefficients?

Do people actually use the word "kaputt" in conversation?

Don't understand why (5 | -2) > 0 is False where (5 or -2) > 0 is True

10 year ban after applying for a UK student visa



Hackerrank All Women's Codesprint 2019: Name the Product


Maximizing XOR HackerRank challengeHackerRank Regex Challenge: Detect HTML TagsProject Euler #8 - Largest product in seriesTime Limit Exceeded for build_max_heapFinding shortest sequences of integers whose product is larger than nOptimize Performance challenge 'Vinay Queried 'Find the number of substrings of a numerical string greater than a given num stringHackerRank university codesprint array constructionHackerrank: Sherlock and anagram (optimal time complexity)Hackerrank: Prefix neighbors













4












$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 10




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    12 hours ago






  • 2




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    12 hours ago










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    10 hours ago















4












$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 10




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    12 hours ago






  • 2




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    12 hours ago










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    10 hours ago













4












4








4





$begingroup$


Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.










share|improve this question









$endgroup$




Link: https://www.hackerrank.com/contests/hackerrank-all-womens-codesprint-2019/challenges/name-the-product/



Problem




You are contesting to name a new product in your company given the following conditions:



You are given an array of $n$ different names, $names$, where $names_i$ denotes the $i^th$ name and all the names are of length $5$. The distance between any two names is the number of positions in which the characters in these names differ. For example, "bubby" and "bunny" differ in two positions.



You have to choose a name such that the sum of differences of all names in $names$ with the chosen name is maximal. In order to win the contest, give the new product this chosen name.



Note: If there are many such names chose the lexicographically largest one.



Take for example, names = ["bubby", "bunny", "berry"], with length $n = 3$. Then, the name that you should choose is "zzzzz" as this name has no common character with any name in the names list and is also lexicographically the largest.



Function Description



Complete the productName function in the editor below. It should return the lexigraphically largest string of length whose sum of differences with all the names is maximal.



productName has the following parameter(s):



names: array of $n$ names



Input Format



  • The first line contains an integer, $n$, denoting the number of elements in $names$.

  • Each line $i$ of the $n$ subsequent lines (where $0 le i le n$) contains a string describing $names_i$.

Constraints



  • $1 le n le 10^5$

  • All characters in the names are lowercase English alphabets.

  • Each name is of length $5$.

Output Format



  • The output should contain the lexigraphically largest string of length whose sum of differences with all the names is maximal.

Sample Input 0



3
bubby
bunny
berry


Sample Output 0



zzzzz


Explanation 0



  • Difference between $names_0$, bubby, and zzzzz is $5$.

  • Difference between $names_1$, bunny, and zzzzz is $5$.

  • Difference between $names_2$, berry, and zzzzz is $5$.
    So, total difference is 15, which is maximal.

Sample Input 1



3
ready
stedy
zebra


Sample Output 1



yzzzz


Explanation 1



  • Difference between $names_0$, ready, and yzzzz is $5$.

  • Difference between $names_1$, stedy, and yzzzz is $5$.

  • Difference between $names_2$, zebra, and yzzzz is $5$.
    So, total differce is 15, which is maximal.





I would strip the extraneous parts from my solution:



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count

alphabet = "abcdefghijklmnopqrstuvwxyz"
def productName(names):
charmap = [dd(lambda: 0, count(name[i] for name in names)) for i in range(5)]
return "".join(max(alphabet, key=lambda x: (-charmap[i][x], x)) for i in range(5))


I'm concerned with adhering to best practices and maximising performance.







python performance beginner programming-challenge






share|improve this question













share|improve this question











share|improve this question




share|improve this question










asked 12 hours ago









Tobi AlafinTobi Alafin

627110




627110











  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 10




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    12 hours ago






  • 2




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    12 hours ago










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    10 hours ago
















  • $begingroup$
    Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 10




    $begingroup$
    Absolutely not.
    $endgroup$
    – Mast
    12 hours ago






  • 2




    $begingroup$
    See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
    $endgroup$
    – Toby Speight
    12 hours ago










  • $begingroup$
    I think online programming challenges are by default public domain?
    $endgroup$
    – Tobi Alafin
    12 hours ago






  • 3




    $begingroup$
    @TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
    $endgroup$
    – Mast
    10 hours ago















$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
12 hours ago




$begingroup$
Meta comment, writing up the question took me much more time than actually solving the question due to the copious amounts of formatting involved. I would likely submit more questions from this particular codesprint, would leaving out the problem description and merely dropping the link be acceptable?
$endgroup$
– Tobi Alafin
12 hours ago




10




10




$begingroup$
Absolutely not.
$endgroup$
– Mast
12 hours ago




$begingroup$
Absolutely not.
$endgroup$
– Mast
12 hours ago




2




2




$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
12 hours ago




$begingroup$
See Can I include problem statements when posting exercise solutions to Code Review?. In short, a link alone is not sufficient (the question must be complete in itself), but you may need to write the requirements in your own words - unless you have specific permission to copy and republish.
$endgroup$
– Toby Speight
12 hours ago












$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
12 hours ago




$begingroup$
I think online programming challenges are by default public domain?
$endgroup$
– Tobi Alafin
12 hours ago




3




3




$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
10 hours ago




$begingroup$
@TobySpeight Although it's unlikely to be deleted by the community, since the community is explicitly not tasked with legal enforcement. That's SE-employees territory, it goes even beyond the moderators.
$endgroup$
– Mast
10 hours ago










1 Answer
1






active

oldest

votes


















14












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    4 hours ago










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    4 hours ago






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    4 hours ago






  • 2




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    2 hours ago







  • 2




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    2 hours ago











Your Answer





StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);













draft saved

draft discarded


















StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown

























1 Answer
1






active

oldest

votes








1 Answer
1






active

oldest

votes









active

oldest

votes






active

oldest

votes









14












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    4 hours ago










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    4 hours ago






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    4 hours ago






  • 2




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    2 hours ago







  • 2




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    2 hours ago
















14












$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$








  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    4 hours ago










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    4 hours ago






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    4 hours ago






  • 2




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    2 hours ago







  • 2




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    2 hours ago














14












14








14





$begingroup$

Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!






share|improve this answer











$endgroup$



Imports



import math, os, random, re, sys
from collections import defaultdict as dd, Counter as count


Seriously, don't do this. It may be useful to read PEP8 regarding imports again.



  • Imports should be on separate lines.


  • Why do Counter as count? It impairs readability.



    Especially in larger scripts, every Python dev knows Counter, but count could be a random variable and is easy to be overshadowed.



  • You don't use all of the imported modules; just remove them if you don't need them.



  • alphabet = "abcdefghijklmnopqrstuvwxyz"


    Here you missed something that is in the standard lib: from string import ascii_lowercase



Misc




  • This dd(lambda: 0, ... adds no value



    Counter is already a dictionary with default value 0 just remove that part




  • Magic numbers



    5 is a Magic number, you should define it as a CONSTANT:



    NAME_LENGTH = 5


The rest looks good!







share|improve this answer














share|improve this answer



share|improve this answer








edited 11 hours ago









Toby Speight

26.4k742118




26.4k742118










answered 12 hours ago









LudisposedLudisposed

8,82422267




8,82422267







  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    4 hours ago










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    4 hours ago






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    4 hours ago






  • 2




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    2 hours ago







  • 2




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    2 hours ago













  • 6




    $begingroup$
    May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
    $endgroup$
    – jpmc26
    4 hours ago










  • $begingroup$
    They're fault for skipping past the imports IMO. shrugs
    $endgroup$
    – Tobi Alafin
    4 hours ago






  • 5




    $begingroup$
    Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
    $endgroup$
    – Ludisposed
    4 hours ago






  • 2




    $begingroup$
    @TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
    $endgroup$
    – jpmc26
    2 hours ago







  • 2




    $begingroup$
    @jpmc26 That's a solid principle,.. I will use this in future code reviews :)
    $endgroup$
    – Ludisposed
    2 hours ago








6




6




$begingroup$
May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
$endgroup$
– jpmc26
4 hours ago




$begingroup$
May as well avoid aliasing defaultdict, too. Who the heck is going to know what dd is if they skip past the imports?
$endgroup$
– jpmc26
4 hours ago












$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
4 hours ago




$begingroup$
They're fault for skipping past the imports IMO. shrugs
$endgroup$
– Tobi Alafin
4 hours ago




5




5




$begingroup$
Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
4 hours ago




$begingroup$
Respectfully no, the same advice goes for aliasing defaultdict. In this small example it doesn't matter, and it's easy to read, but when you are working on larger projects this can be a true pain in the ***
$endgroup$
– Ludisposed
4 hours ago




2




2




$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
2 hours ago





$begingroup$
@TobiAlafin You need to learn the Principle of Least Astonishment. The biggest thing you should do to make your code readable and maintainable is to avoid doing things that are surprising. Aliasing something that's referenced exactly once is the code is weird. It's surprising. So is abbreviating names from the standard library. Don't do things that will surprise other developers. Do normal things. Great code is so obvious, it makes you think you could have easily thought of it.
$endgroup$
– jpmc26
2 hours ago





2




2




$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
2 hours ago





$begingroup$
@jpmc26 That's a solid principle,.. I will use this in future code reviews :)
$endgroup$
– Ludisposed
2 hours ago


















draft saved

draft discarded
















































Thanks for contributing an answer to Code Review Stack Exchange!


  • Please be sure to answer the question. Provide details and share your research!

But avoid


  • Asking for help, clarification, or responding to other answers.

  • Making statements based on opinion; back them up with references or personal experience.

Use MathJax to format equations. MathJax reference.


To learn more, see our tips on writing great answers.




draft saved


draft discarded














StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215662%2fhackerrank-all-womens-codesprint-2019-name-the-product%23new-answer', 'question_page');

);

Post as a guest















Required, but never shown





















































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown

































Required, but never shown














Required, but never shown












Required, but never shown







Required, but never shown







Popular posts from this blog

Àrd-bhaile Cathair chruinne/Baile mòr cruinne | Artagailean ceangailte | Clàr-taice na seòladaireachd

대한민국 목차 국명 지리 역사 정치 국방 경제 사회 문화 국제 순위 관련 항목 각주 외부 링크 둘러보기 메뉴북위 37° 34′ 08″ 동경 126° 58′ 36″ / 북위 37.568889° 동경 126.976667°  / 37.568889; 126.976667ehThe Korean Repository문단을 편집문단을 편집추가해Clarkson PLC 사Report for Selected Countries and Subjects-Korea“Human Development Index and its components: P.198”“http://www.law.go.kr/%EB%B2%95%EB%A0%B9/%EB%8C%80%ED%95%9C%EB%AF%BC%EA%B5%AD%EA%B5%AD%EA%B8%B0%EB%B2%95”"한국은 국제법상 한반도 유일 합법정부 아니다" - 오마이뉴스 모바일Report for Selected Countries and Subjects: South Korea격동의 역사와 함께한 조선일보 90년 : 조선일보 인수해 혁신시킨 신석우, 임시정부 때는 '대한민국' 국호(國號) 정해《우리가 몰랐던 우리 역사: 나라 이름의 비밀을 찾아가는 역사 여행》“남북 공식호칭 ‘남한’‘북한’으로 쓴다”“Corea 대 Korea, 누가 이긴 거야?”국내기후자료 - 한국[김대중 前 대통령 서거] 과감한 구조개혁 'DJ노믹스'로 최단기간 환란극복 :: 네이버 뉴스“이라크 "韓-쿠르드 유전개발 MOU 승인 안해"(종합)”“해외 우리국민 추방사례 43%가 일본”차기전차 K2'흑표'의 세계 최고 전력 분석, 쿠키뉴스 엄기영, 2007-03-02두산인프라, 헬기잡는 장갑차 'K21'...내년부터 공급, 고뉴스 이대준, 2008-10-30과거 내용 찾기mk 뉴스 - 구매력 기준으로 보면 한국 1인당 소득 3만弗과거 내용 찾기"The N-11: More Than an Acronym"Archived조선일보 최우석, 2008-11-01Global 500 2008: Countries - South Korea“몇년째 '시한폭탄'... 가계부채, 올해는 터질까”가구당 부채 5000만원 처음 넘어서“‘빚’으로 내몰리는 사회.. 위기의 가계대출”“[경제365] 공공부문 부채 급증…800조 육박”“"소득 양극화 다소 완화...불평등은 여전"”“공정사회·공생발전 한참 멀었네”iSuppli,08年2QのDRAMシェア・ランキングを発表(08/8/11)South Korea dominates shipbuilding industry | Stock Market News & Stocks to Watch from StraightStocks한국 자동차 생산, 3년 연속 세계 5위자동차수출 '현대-삼성 웃고 기아-대우-쌍용은 울고' 과거 내용 찾기동반성장위 창립 1주년 맞아Archived"중기적합 3개업종 합의 무시한 채 선정"李대통령, 사업 무분별 확장 소상공인 생계 위협 질타삼성-LG, 서민업종인 빵·분식사업 잇따라 철수상생은 뒷전…SSM ‘몸집 불리기’ 혈안Archived“경부고속도에 '아시안하이웨이' 표지판”'철의 실크로드' 앞서 '말(言)의 실크로드'부터, 프레시안 정창현, 2008-10-01“'서울 지하철은 안전한가?'”“서울시 “올해 안에 모든 지하철역 스크린도어 설치””“부산지하철 1,2호선 승강장 안전펜스 설치 완료”“전교조, 정부 노조 통계서 처음 빠져”“[Weekly BIZ] 도요타 '제로 이사회'가 리콜 사태 불러들였다”“S Korea slams high tuition costs”““정치가 여론 양극화 부채질… 합리주의 절실””“〈"`촛불집회'는 민주주의의 질적 변화 상징"〉”““촛불집회가 민주주의 왜곡 초래””“국민 65%, "한국 노사관계 대립적"”“한국 국가경쟁력 27위‥노사관계 '꼴찌'”“제대로 형성되지 않은 대한민국 이념지형”“[신년기획-갈등의 시대] 갈등지수 OECD 4위…사회적 손실 GDP 27% 무려 300조”“2012 총선-대선의 키워드는 '국민과 소통'”“한국 삶의 질 27위, 2000년과 2008년 연속 하위권 머물러”“[해피 코리아] 행복점수 68점…해외 평가선 '낙제점'”“한국 어린이·청소년 행복지수 3년 연속 OECD ‘꼴찌’”“한국 이혼율 OECD중 8위”“[통계청] 한국 이혼율 OECD 4위”“오피니언 [이렇게 생각한다] `부부의 날` 에 돌아본 이혼율 1위 한국”“Suicide Rates by Country, Global Health Observatory Data Repository.”“1. 또 다른 차별”“오피니언 [편집자에게] '왕따'와 '패거리 정치' 심리는 닮은꼴”“[미래한국리포트] 무한경쟁에 빠진 대한민국”“대학생 98% "외모가 경쟁력이라는 말 동의"”“특급호텔 웨딩·200만원대 유모차… "남보다 더…" 호화病, 고질병 됐다”“[스트레스 공화국] ① 경쟁사회, 스트레스 쌓인다”““매일 30여명 자살 한국, 의사보다 무속인에…””“"자살 부르는 '우울증', 환자 중 85% 치료 안 받아"”“정신병원을 가다”“대한민국도 ‘묻지마 범죄’,안전지대 아니다”“유엔 "학생 '성적 지향'에 따른 차별 금지하라"”“유엔아동권리위원회 보고서 및 번역본 원문”“고졸 성공스토리 담은 '제빵왕 김탁구' 드라마 나온다”“‘빛 좋은 개살구’ 고졸 취업…실습 대신 착취”원본 문서“정신건강, 사회적 편견부터 고쳐드립니다”‘소통’과 ‘행복’에 목 마른 사회가 잠들어 있던 ‘심리학’ 깨웠다“[포토] 사유리-곽금주 교수의 유쾌한 심리상담”“"올해 한국인 평균 영화관람횟수 세계 1위"(종합)”“[게임연중기획] 게임은 문화다-여가활동 1순위 게임”“영화속 ‘영어 지상주의’ …“왠지 씁쓸한데””“2월 `신문 부수 인증기관` 지정..방송법 후속작업”“무료신문 성장동력 ‘차별성’과 ‘갈등해소’”대한민국 국회 법률지식정보시스템"Pew Research Center's Religion & Public Life Project: South Korea"“amp;vwcd=MT_ZTITLE&path=인구·가구%20>%20인구총조사%20>%20인구부문%20>%20 총조사인구(2005)%20>%20전수부문&oper_YN=Y&item=&keyword=종교별%20인구& amp;lang_mode=kor&list_id= 2005년 통계청 인구 총조사”원본 문서“한국인이 좋아하는 취미와 운동 (2004-2009)”“한국인이 좋아하는 취미와 운동 (2004-2014)”Archived“한국, `부분적 언론자유국' 강등〈프리덤하우스〉”“국경없는기자회 "한국, 인터넷감시 대상국"”“한국, 조선산업 1위 유지(S. Korea Stays Top Shipbuilding Nation) RZD-Partner Portal”원본 문서“한국, 4년 만에 ‘선박건조 1위’”“옛 마산시,인터넷속도 세계 1위”“"한국 초고속 인터넷망 세계1위"”“인터넷·휴대폰 요금, 외국보다 훨씬 비싸”“한국 관세행정 6년 연속 세계 '1위'”“한국 교통사고 사망자 수 OECD 회원국 중 2위”“결핵 후진국' 한국, 환자가 급증한 이유는”“수술은 신중해야… 자칫하면 생명 위협”대한민국분류대한민국의 지도대한민국 정부대표 다국어포털대한민국 전자정부대한민국 국회한국방송공사about korea and information korea브리태니커 백과사전(한국편)론리플래닛의 정보(한국편)CIA의 세계 정보(한국편)마리암 부디아 (Mariam Budia),『한국: 하늘이 내린 한 폭의 그림』, 서울: 트랜스라틴 19호 (2012년 3월)대한민국ehehehehehehehehehehehehehehWorldCat132441370n791268020000 0001 2308 81034078029-6026373548cb11863345f(데이터)00573706ge128495

Cannot Extend partition with GParted The 2019 Stack Overflow Developer Survey Results Are In Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern) 2019 Community Moderator Election ResultsCan't increase partition size with GParted?GParted doesn't recognize the unallocated space after my current partitionWhat is the best way to add unallocated space located before to Ubuntu 12.04 partition with GParted live?I can't figure out how to extend my Arch home partition into free spaceGparted Linux Mint 18.1 issueTrying to extend but swap partition is showing as Unknown in Gparted, shows proper from fdiskRearrange partitions in gparted to extend a partitionUnable to extend partition even though unallocated space is next to it using GPartedAllocate free space to root partitiongparted: how to merge unallocated space with a partition